Fix resin doors not closing on mob/living if they are merged with weeds #4990
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
changed the title
fira
requested changes
Nov 21, 2023
fira
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR simply changes the mob/living check in
/obj/structure/mineral_door/resin/Close()to also account for whether they are merged with the weeds. As soon as xeno corpses are also merging with weeds this will handle them too.Explain why it's good for the game
Although I think this is a very rare situation, it can be especially confusing if a fully weeded corpse that intentionally is hard to see is causing a door to not close (seemingly arbitrarily).
Testing Photographs and Procedure
Screenshots & Videos
Untitled.mp4
Changelog
🆑 Drathek
fix: Resin doors will now close on dead mobs that are merged with weeds (currently only human).
fix: Resin doors will now restart their closing timer each open making the delay to close consistent.
code: Added a TRAIT_MERGED_WITH_WEEDS that is set whenever the mob is currently merged with weeds.
/:cl: